netdev - Re: [RFC PATCH] can: can327: remove useless header inclusions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABGWkvpK25WGjp76_=Jfd9sMk5Dvj84VnVuc3iuroKR0tJEv+Q@mail.gmail.com>
Date:   Mon, 18 Jul 2022 09:18:37 +0200
From:   Dario Binacchi <dario.binacchi@...rulasolutions.com>
To:     Max Staudt <max@...as.org>
Cc:     linux-kernel@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Marc Kleine-Budde <mkl@...gutronix.de>,
        Paolo Abeni <pabeni@...hat.com>,
        Wolfgang Grandegger <wg@...ndegger.com>,
        linux-can@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [RFC PATCH] can: can327: remove useless header inclusions

Hi Max,

On Sun, Jul 17, 2022 at 11:50 PM Max Staudt <max@...as.org> wrote:
>
> On Sat, 16 Jul 2022 19:02:01 +0200
> Dario Binacchi <dario.binacchi@...rulasolutions.com> wrote:
>
> > -#include <linux/init.h>
> >  #include <linux/module.h>
> > -
> > -#include <linux/bitops.h>
> > -#include <linux/ctype.h>
> > -#include <linux/errno.h>
> > -#include <linux/kernel.h>
> > -#include <linux/list.h>
> > -#include <linux/lockdep.h>
> > -#include <linux/netdevice.h>
> > -#include <linux/skbuff.h>
> > -#include <linux/spinlock.h>
> > -#include <linux/string.h>
> >  #include <linux/tty.h>
> > -#include <linux/tty_ldisc.h>
> > -#include <linux/workqueue.h>
> > -
> > -#include <uapi/linux/tty.h>
> > -
> > -#include <linux/can.h>
> >  #include <linux/can/dev.h>
> > -#include <linux/can/error.h>
> >  #include <linux/can/rx-offload.h>
>
> AFAIK, the coding style is to not rely on headers including other
> headers. Instead, the appropriate header for every symbol used should
> be included.

Thanks for the explanation.

>
> This is also valid for the similar patch you submitted for slcan.

Probably something can be removed (if_arp.h, if_ether.h, ...).
I will take can327.c as a reference.

Thanks and regards,
Dario

>
>
> Unless something has changed, this is a NAK from me, sorry.
>
>
> Max



-- 

Dario Binacchi

Embedded Linux Developer

dario.binacchi@...rulasolutions.com

__________________________________


Amarula Solutions SRL

Via Le Canevare 30, 31100 Treviso, Veneto, IT

T. +39 042 243 5310
info@...rulasolutions.com

www.amarulasolutions.com