netdev - Re: [PATCH v2 1/1] dt-bindings: net: fsl,fec: Add nvmem-cells / nvmem-cell-names properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220718215016.GA3615606-robh@kernel.org>
Date:   Mon, 18 Jul 2022 15:50:16 -0600
From:   Rob Herring <robh@...nel.org>
To:     Alexander Stein <alexander.stein@...tq-group.com>
Cc:     Joakim Zhang <qiangqing.zhang@....com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH v2 1/1] dt-bindings: net: fsl,fec: Add nvmem-cells /
 nvmem-cell-names properties

On Fri, Jul 15, 2022 at 10:06:40AM +0200, Alexander Stein wrote:
> These properties are inherited from ethernet-controller.yaml.
> This fixes the dt_binding_check warning:
> imx8mm-tqma8mqml-mba8mx.dt.yaml: ethernet@...e0000: 'nvmem-cell-names',
> 'nvmem-cells' do not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Signed-off-by: Alexander Stein <alexander.stein@...tq-group.com>
> ---
> Changes in v2:
> * Add amount and names of nvmem-cells (copied from ethernet-controller.yaml)
> 
>  Documentation/devicetree/bindings/net/fsl,fec.yaml | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/fsl,fec.yaml b/Documentation/devicetree/bindings/net/fsl,fec.yaml
> index daa2f79a294f..b5b55dca08cb 100644
> --- a/Documentation/devicetree/bindings/net/fsl,fec.yaml
> +++ b/Documentation/devicetree/bindings/net/fsl,fec.yaml
> @@ -121,6 +121,14 @@ properties:
>  
>    mac-address: true
>  
> +  nvmem-cells:
> +    maxItems: 1
> +    description:
> +      Reference to an nvmem node for the MAC address
> +
> +  nvmem-cell-names:
> +    const: mac-address

Sorry, steered you wrong on this. I didn't realize 
ethernet-controller.yaml already defined these. You just need 
'unevaluatedProperties: false' instead additionalProperties.

I'm not sure what the FIXME for the additionalProperties is all about 
though.

Rob