netdev - Re: Re: [PATCH v2 1/1] dt-bindings: net: fsl, fec: Add nvmem-cells / nvmem-cell-names properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1924174.PYKUYFuaPT@steina-w>
Date:   Wed, 20 Jul 2022 08:25:04 +0200
From:   Alexander Stein <alexander.stein@...tq-group.com>
To:     Rob Herring <robh@...nel.org>
Cc:     Joakim Zhang <qiangqing.zhang@....com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: Re: [PATCH v2 1/1] dt-bindings: net: fsl,
 fec: Add nvmem-cells / nvmem-cell-names properties

Am Montag, 18. Juli 2022, 23:50:16 CEST schrieb Rob Herring:
> On Fri, Jul 15, 2022 at 10:06:40AM +0200, Alexander Stein wrote:
> > These properties are inherited from ethernet-controller.yaml.
> > This fixes the dt_binding_check warning:
> > imx8mm-tqma8mqml-mba8mx.dt.yaml: ethernet@...e0000: 'nvmem-cell-names',
> > 'nvmem-cells' do not match any of the regexes: 'pinctrl-[0-9]+'
> > 
> > Signed-off-by: Alexander Stein <alexander.stein@...tq-group.com>
> > ---
> > Changes in v2:
> > * Add amount and names of nvmem-cells (copied from
> > ethernet-controller.yaml)> 
> >  Documentation/devicetree/bindings/net/fsl,fec.yaml | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/net/fsl,fec.yaml
> > b/Documentation/devicetree/bindings/net/fsl,fec.yaml index
> > daa2f79a294f..b5b55dca08cb 100644
> > --- a/Documentation/devicetree/bindings/net/fsl,fec.yaml
> > +++ b/Documentation/devicetree/bindings/net/fsl,fec.yaml
> > 
> > @@ -121,6 +121,14 @@ properties:
> >    mac-address: true
> > 
> > +  nvmem-cells:
> > +    maxItems: 1
> > +    description:
> > +      Reference to an nvmem node for the MAC address
> > +
> > +  nvmem-cell-names:
> > +    const: mac-address
> 
> Sorry, steered you wrong on this. I didn't realize
> ethernet-controller.yaml already defined these. You just need
> 'unevaluatedProperties: false' instead additionalProperties.

Ok, will come up with a new version.

> I'm not sure what the FIXME for the additionalProperties is all about
> though.

I guess this is about the deprecated properties (phy-reset-gpios, phy-reset-
duration, phy-reset-active-high, phy-reset-post-delay), which you can see in 
the example. There is e.g. phy-reset-gpios and put to MAC node, but nowadays 
this should be reset-gpios property in PHY node (see ethernet-phy.yaml)
Unfortunately you can't get rid of it until a single, common MDIO bus is 
supported by multiple fec instances, see [1].

Best regards,
Alexander

[1] https://www.spinics.net/lists/kernel/msg4110563.html