netdev - Re: [PATCH net] net/tls: Fix race in TLS device down flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <165814141330.26482.840632241080820266.git-patchwork-notify@kernel.org>
Date:   Mon, 18 Jul 2022 10:50:13 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Tariq Toukan <tariqt@...dia.com>
Cc:     borisp@...dia.com, john.fastabend@...il.com, kuba@...nel.org,
        davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
        netdev@...r.kernel.org, saeedm@...dia.com, gal@...dia.com,
        maximmi@...dia.com
Subject: Re: [PATCH net] net/tls: Fix race in TLS device down flow

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@...emloft.net>:

On Fri, 15 Jul 2022 11:42:16 +0300 you wrote:
> Socket destruction flow and tls_device_down function sync against each
> other using tls_device_lock and the context refcount, to guarantee the
> device resources are freed via tls_dev_del() by the end of
> tls_device_down.
> 
> In the following unfortunate flow, this won't happen:
> - refcount is decreased to zero in tls_device_sk_destruct.
> - tls_device_down starts, skips the context as refcount is zero, going
>   all the way until it flushes the gc work, and returns without freeing
>   the device resources.
> - only then, tls_device_queue_ctx_destruction is called, queues the gc
>   work and frees the context's device resources.
> 
> [...]

Here is the summary with links:
  - [net] net/tls: Fix race in TLS device down flow
    https://git.kernel.org/netdev/net/c/f08d8c1bb97c

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html