netdev - Re: [PATCH v1 net-next] selftests: net: af_unix: Fix a build error of unix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220720004305.15822-1-kuniyu@amazon.com>
Date:   Tue, 19 Jul 2022 17:43:05 -0700
From:   Kuniyuki Iwashima <kuniyu@...zon.com>
To:     <kuba@...nel.org>
CC:     <davem@...emloft.net>, <edumazet@...gle.com>, <kuni1840@...il.com>,
        <kuniyu@...zon.com>, <lkp@...el.com>, <netdev@...r.kernel.org>,
        <pabeni@...hat.com>
Subject: Re: [PATCH v1 net-next] selftests: net: af_unix: Fix a build error of unix_connect.c.

From:   Jakub Kicinski <kuba@...nel.org>
Date:   Tue, 19 Jul 2022 17:32:01 -0700
> On Mon, 18 Jul 2022 09:23:50 -0700 Kuniyuki Iwashima wrote:
> > This patch fixes a build error reported in the link. [0]
> > 
> >   unix_connect.c: In function ‘unix_connect_test’:
> >   unix_connect.c:115:55: error: expected identifier before ‘(’ token
> >    #define offsetof(type, member) ((size_t)&((type *)0)->(member))
> >                                                        ^
> >   unix_connect.c:128:12: note: in expansion of macro ‘offsetof’
> >     addrlen = offsetof(struct sockaddr_un, sun_path) + variant->len;
> >               ^~~~~~~~
> 
> Can we delete this define and use stddef.h instead?  man offsetof
> This is not kernel code the C standard lib is at our disposal.

Ah, it works.
I'll respin v2.

Thank you!