netdev - Re: [PATCH net-next] tcp: fix condition for increasing pingpong count

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220719174915.48f830b4@kernel.org>
Date:   Tue, 19 Jul 2022 17:49:15 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     LemmyHuang <hlm3280@....com>
Cc:     edumazet@...gle.com, davem@...emloft.net, dsahern@...nel.org,
        pabeni@...hat.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] tcp: fix condition for increasing pingpong
 count

On Tue, 19 Jul 2022 21:01:37 +0800 LemmyHuang wrote:
> -	if (before(tp->lsndtime, icsk->icsk_ack.lrcvtime) &&
> +	if ((tp->lsndtime <= icsk->icsk_ack.lrcvtime) &&

Are you sure you don't need to take care of the values wrapping?
before() does that. You may want !after() if you want to allow equal.