netdev - Re: [patch net-next v3 06/11] mlxsw: core_linecards: Probe provisioned line cards for devices and expose FW version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Ytl4dhY8c8GC9z1M@nanopsycho>
Date:   Thu, 21 Jul 2022 18:01:58 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     Ido Schimmel <idosch@...dia.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
        petrm@...dia.com, pabeni@...hat.com, edumazet@...gle.com,
        mlxsw@...dia.com, saeedm@...dia.com, snelson@...sando.io
Subject: Re: [patch net-next v3 06/11] mlxsw: core_linecards: Probe
 provisioned line cards for devices and expose FW version

Thu, Jul 21, 2022 at 10:11:48AM CEST, idosch@...dia.com wrote:
>The subject is misleading, only ready/active line cards are probed for
>FW version, not merely provisioned ones.

Fixed.


>
>On Wed, Jul 20, 2022 at 05:12:29PM +0200, Jiri Pirko wrote:
>> From: Jiri Pirko <jiri@...dia.com>
>> 
>> In case the line card is provisioned, go over all possible existing
>
>Same comment

Fixed.


>
>> devices (gearboxes) on it and expose FW version of the flashable one.
>> 
>> Example:
>> 
>> $ devlink dev info auxiliary/mlxsw_core.lc.0
>> auxiliary/mlxsw_core.lc.0:
>>   versions:
>>       fixed:
>>         hw.revision 0
>>       running:
>>         ini.version 4
>>         fw 19.2010.1312
>> 
>> Signed-off-by: Jiri Pirko <jiri@...dia.com>
>
>Assuming the above will be fixed in next version (it's already marked as
>"Changes Requested"):
>
>Reviewed-by: Ido Schimmel <idosch@...dia.com>