netdev - Re: [PATCH v2 1/3] dt-bindings: net: cdns,macb: Add versal compatible string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 25 Jul 2022 13:33:56 -0600
From:   Rob Herring <robh@...nel.org>
To:     Harini Katakam <harini.katakam@...inx.com>
Cc:     nicolas.ferre@...rochip.com, davem@...emloft.net,
        claudiu.beznea@...rochip.com, kuba@...nel.org, edumazet@...gle.com,
        pabeni@...hat.com, krzysztof.kozlowski+dt@...aro.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        michal.simek@...inx.com, harinikatakamlinux@...il.com,
        harini.katakam@....com, devicetree@...r.kernel.org,
        radhey.shyam.pandey@...inx.com
Subject: Re: [PATCH v2 1/3] dt-bindings: net: cdns,macb: Add versal
 compatible string

On Fri, Jul 22, 2022 at 04:33:28PM +0530, Harini Katakam wrote:
> From: Radhey Shyam Pandey <radhey.shyam.pandey@...inx.com>
> 
> Add versal compatible string.
> 
> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@...inx.com>
> Signed-off-by: Harini Katakam <harini.katakam@...inx.com>
> ---
> v2:
> Sort compatible string alphabetically.
> 
>  Documentation/devicetree/bindings/net/cdns,macb.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml b/Documentation/devicetree/bindings/net/cdns,macb.yaml
> index 9c92156869b2..762deccd3640 100644
> --- a/Documentation/devicetree/bindings/net/cdns,macb.yaml
> +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml
> @@ -20,6 +20,7 @@ properties:
>  
>        - items:
>            - enum:
> +              - cdns,versal-gem       # Xilinx Versal
>                - cdns,zynq-gem         # Xilinx Zynq-7xxx SoC
>                - cdns,zynqmp-gem       # Xilinx Zynq Ultrascale+ MPSoC

Uh, how did we start this pattern? The vendor here is Xilinx, not 
Cadence. It should be xlnx,versal-gem instead.

>            - const: cdns,gem           # Generic
> -- 
> 2.17.1
> 
>