[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <017a3722-d61f-6762-d17f-57417f1e3165@linaro.org>
Date: Mon, 25 Jul 2022 21:39:49 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Rob Herring <robh@...nel.org>,
Harini Katakam <harini.katakam@...inx.com>
Cc: nicolas.ferre@...rochip.com, davem@...emloft.net,
claudiu.beznea@...rochip.com, kuba@...nel.org, edumazet@...gle.com,
pabeni@...hat.com, krzysztof.kozlowski+dt@...aro.org,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
michal.simek@...inx.com, harinikatakamlinux@...il.com,
harini.katakam@....com, devicetree@...r.kernel.org,
radhey.shyam.pandey@...inx.com
Subject: Re: [PATCH v2 1/3] dt-bindings: net: cdns,macb: Add versal compatible
string
On 25/07/2022 21:33, Rob Herring wrote:
> On Fri, Jul 22, 2022 at 04:33:28PM +0530, Harini Katakam wrote:
>> From: Radhey Shyam Pandey <radhey.shyam.pandey@...inx.com>
>>
>> Add versal compatible string.
>>
>> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@...inx.com>
>> Signed-off-by: Harini Katakam <harini.katakam@...inx.com>
>> ---
>> v2:
>> Sort compatible string alphabetically.
>>
>> Documentation/devicetree/bindings/net/cdns,macb.yaml | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml b/Documentation/devicetree/bindings/net/cdns,macb.yaml
>> index 9c92156869b2..762deccd3640 100644
>> --- a/Documentation/devicetree/bindings/net/cdns,macb.yaml
>> +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml
>> @@ -20,6 +20,7 @@ properties:
>>
>> - items:
>> - enum:
>> + - cdns,versal-gem # Xilinx Versal
>> - cdns,zynq-gem # Xilinx Zynq-7xxx SoC
>> - cdns,zynqmp-gem # Xilinx Zynq Ultrascale+ MPSoC
>
> Uh, how did we start this pattern? The vendor here is Xilinx, not
> Cadence. It should be xlnx,versal-gem instead.
I missed that piece entirely... Un-ack.
Best regards,
Krzysztof
Powered by blists - more mailing lists