netdev - Re: [PATCH net] tcp: md5: fix IPv4-mapped support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <668b7bc0-6ff5-638f-6693-b7c7666f8f45@kernel.org>
Date:   Tue, 26 Jul 2022 13:05:52 -0600
From:   David Ahern <dsahern@...nel.org>
To:     Eric Dumazet <edumazet@...gle.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        netdev <netdev@...r.kernel.org>,
        Eric Dumazet <eric.dumazet@...il.com>,
        Brian Vazquez <brianvv@...gle.com>,
        Dmitry Safonov <dima@...sta.com>,
        Leonard Crestez <cdleonard@...il.com>
Subject: Re: [PATCH net] tcp: md5: fix IPv4-mapped support

On 7/26/22 11:57 AM, Eric Dumazet wrote:
> Although fcnal-test.sh uses ~45 minutes currently :/
> Maybe we should make it multi netns and multi threaded to speed up things.
> 
> And/or replace various "sleep 1" with more appropriate sync to make
> this faster and not flaky in case of system load.

There are currently 700+ permutations (800+ if Mike's vrf patch is only
fcnal-test). That's why the script takes a `-t TEST` argument - to only
run a subset.

nettest now has the capability for 1 command to run both client and
server in different namespaces. I have a branch that did the conversion
of fcnal-test.sh; validating the output to ensure no degradation in test
results (not just pass / fail but tests "fail" (negative tests) for the
right reason) took more time than I had. In the end it did not shorten
the test time by any significant margin so lost the motivation to wade
through the output on the before and after.