lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 1 Aug 2022 18:59:56 +0700 From: Ammar Faizi <ammarfaizi2@...weeb.org> To: "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com> Cc: Ammar Faizi <ammarfaizi2@...weeb.org>, kernel test robot <lkp@...el.com>, Dan Carpenter <dan.carpenter@...cle.com>, Moshe Shemesh <moshe@...dia.com>, Jiri Pirko <jiri@...dia.com>, Fernanda Ma'rouf <fernandafmr12@...weeb.org>, netdev Mailing List <netdev@...r.kernel.org>, GNU/Weeb Mailing List <gwml@...r.gnuweeb.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, kbuild Mailing List <kbuild@...ts.01.org>, kbuild-all Mailing List <kbuild-all@...ts.01.org> Subject: [PATCH] net: devlink: Fix missing mutex_unlock() call From: Ammar Faizi <ammarfaizi2@...weeb.org> Commit 2dec18ad826f forgets to call mutex_unlock() before the function returns in the error path: New smatch warnings: net/core/devlink.c:6392 devlink_nl_cmd_region_new() warn: inconsistent \ returns '®ion->snapshot_lock'. Make sure we call mutex_unlock() in this error path. Reported-by: kernel test robot <lkp@...el.com> Reported-by: Dan Carpenter <dan.carpenter@...cle.com> Fixes: 2dec18ad826f52658f7781ee995d236cc449b678 ("net: devlink: remove region snapshots list dependency on devlink->lock") Signed-off-by: Ammar Faizi <ammarfaizi2@...weeb.org> --- net/core/devlink.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/net/core/devlink.c b/net/core/devlink.c index 889e7e3d3e8a..5da5c7cca98a 100644 --- a/net/core/devlink.c +++ b/net/core/devlink.c @@ -6315,8 +6315,10 @@ devlink_nl_cmd_region_new(struct sk_buff *skb, struct genl_info *info) snapshot = devlink_region_snapshot_get_by_id(region, snapshot_id); - if (WARN_ON(!snapshot)) - return -EINVAL; + if (WARN_ON(!snapshot)) { + err = -EINVAL; + goto unlock; + } msg = devlink_nl_region_notify_build(region, snapshot, DEVLINK_CMD_REGION_NEW, base-commit: 0a324c3263f1e456f54dd8dc8ce58575aea776bc -- Ammar Faizi
Powered by blists - more mailing lists