lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 1 Aug 2022 16:40:50 +0200 From: Jiri Pirko <jiri@...nulli.us> To: Ammar Faizi <ammarfaizi2@...weeb.org> Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, kernel test robot <lkp@...el.com>, Dan Carpenter <dan.carpenter@...cle.com>, Moshe Shemesh <moshe@...dia.com>, Jiri Pirko <jiri@...dia.com>, Fernanda Ma'rouf <fernandafmr12@...weeb.org>, netdev Mailing List <netdev@...r.kernel.org>, GNU/Weeb Mailing List <gwml@...r.gnuweeb.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, kbuild Mailing List <kbuild@...ts.01.org>, kbuild-all Mailing List <kbuild-all@...ts.01.org> Subject: Re: [PATCH] net: devlink: Fix missing mutex_unlock() call Mon, Aug 01, 2022 at 01:59:56PM CEST, ammarfaizi2@...weeb.org wrote: >From: Ammar Faizi <ammarfaizi2@...weeb.org> > >Commit 2dec18ad826f forgets to call mutex_unlock() before the function >returns in the error path: > > New smatch warnings: > net/core/devlink.c:6392 devlink_nl_cmd_region_new() warn: inconsistent \ > returns '®ion->snapshot_lock'. > >Make sure we call mutex_unlock() in this error path. > >Reported-by: kernel test robot <lkp@...el.com> >Reported-by: Dan Carpenter <dan.carpenter@...cle.com> >Fixes: 2dec18ad826f52658f7781ee995d236cc449b678 ("net: devlink: remove region snapshots list dependency on devlink->lock") >Signed-off-by: Ammar Faizi <ammarfaizi2@...weeb.org> Reviewed-by: Jiri Pirko <jiri@...dia.com> Thanks for the fix!
Powered by blists - more mailing lists