lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 1 Aug 2022 16:40:50 +0200
From:   Jiri Pirko <>
To:     Ammar Faizi <>
Cc:     "David S. Miller" <>,
        Eric Dumazet <>,
        Jakub Kicinski <>,
        Paolo Abeni <>,
        kernel test robot <>,
        Dan Carpenter <>,
        Moshe Shemesh <>, Jiri Pirko <>,
        Fernanda Ma'rouf <>,
        netdev Mailing List <>,
        GNU/Weeb Mailing List <>,
        Linux Kernel Mailing List <>,
        kbuild Mailing List <>,
        kbuild-all Mailing List <>
Subject: Re: [PATCH] net: devlink: Fix missing mutex_unlock() call

Mon, Aug 01, 2022 at 01:59:56PM CEST, wrote:
>From: Ammar Faizi <>
>Commit 2dec18ad826f forgets to call mutex_unlock() before the function
>returns in the error path:
>   New smatch warnings:
>   net/core/devlink.c:6392 devlink_nl_cmd_region_new() warn: inconsistent \
>   returns '&region->snapshot_lock'.
>Make sure we call mutex_unlock() in this error path.
>Reported-by: kernel test robot <>
>Reported-by: Dan Carpenter <>
>Fixes: 2dec18ad826f52658f7781ee995d236cc449b678 ("net: devlink: remove region snapshots list dependency on devlink->lock")
>Signed-off-by: Ammar Faizi <>

Reviewed-by: Jiri Pirko <>

Thanks for the fix!

Powered by blists - more mailing lists