netdev - Re: [PATCH v3 net 1/4] net: bonding: replace dev_trans_start() with the jiffies of the last ARP/NS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <10961.1659457758@famine>
Date:   Tue, 02 Aug 2022 09:29:18 -0700
From:   Jay Vosburgh <jay.vosburgh@...onical.com>
To:     Jakub Kicinski <kuba@...nel.org>
cc:     Vladimir Oltean <vladimir.oltean@....com>,
        Paolo Abeni <pabeni@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Jonathan Toppins <jtoppins@...hat.com>,
        Veaceslav Falico <vfalico@...il.com>,
        Andy Gospodarek <andy@...yhouse.net>,
        Hangbin Liu <liuhangbin@...il.com>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Pirko <jiri@...nulli.us>,
        Nikolay Aleksandrov <razor@...ckwall.org>,
        Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [PATCH v3 net 1/4] net: bonding: replace dev_trans_start() with the jiffies of the last ARP/NS

Jakub Kicinski <kuba@...nel.org> wrote:

>On Tue, 02 Aug 2022 11:05:19 +0200 Paolo Abeni wrote:
>> In any case, this looks like a significative rework, do you mind
>> consider it for the net-next, when it re-open?
>
>It does seem like it could be a lot for stable.
>
>Perhaps we could take:
>
>https://lore.kernel.org/all/20220727152000.3616086-1-vladimir.oltean@nxp.com/
>
>as is, without the extra work Stephen asked for (since it's gonna be
>reverted in net-next, anyway)? How do you feel about that option?

	Would that mean that the older stable kernels end up with a
different implementation that's unique to stable, or are you proposing
to take the linked patch,

"net/sched: make dev_trans_start() have a better chance of working with
stacked interfaces"

	as a complete replacement for this series?

	Alternatively, would it be more comfortable to just put this
patch (1/4) to stable and not backport the others?  If I understand
correctly, this patch enables the functionality, and the others are
cleaning up logic that isn't necessary after 1/4 is applied.

	I think this patch will work as described, and haven't thought
of any non-crazy scenarios that it could break (e.g., things that depend
on the "drop after arp_send" discussed elsewhere).

	I also think this patch is preferable to the "stacked
interfaces" patch: it limits the scope to just bonding, doesn't change
dev_trans_start() itself, and should cover any type of interface in a
bond.

	-J

---
	-Jay Vosburgh, jay.vosburgh@...onical.com