netdev - Re: [PATCH v3 net] geneve: fix TOS inheriting for ipv4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a7107bad-cb41-f612-2ff1-a67ab5830865@kernel.org>
Date:   Wed, 3 Aug 2022 09:36:49 -0600
From:   David Ahern <dsahern@...nel.org>
To:     Matthias May <matthias.may@...termo.com>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, yoshfuji@...ux-ipv6.org, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, nicolas.dichtel@...nd.com,
        eyal.birger@...il.com, linux-kernel@...r.kernel.org,
        jesse@...ira.com, pshelar@...ira.com, tgraf@...g.ch
Subject: Re: [PATCH v3 net] geneve: fix TOS inheriting for ipv4

On 8/2/22 6:20 AM, Matthias May wrote:
> @@ -822,6 +823,7 @@ static struct rtable *geneve_get_v4_rt(struct sk_buff *skb,
>  		use_cache = false;
>  	}
>  	fl4->flowi4_tos = RT_TOS(tos);

Could make this optional with
	if (full_tos)
> +		*full_tos = tos;
>  
>  	dst_cache = (struct dst_cache *)&info->dst_cache;
>  	if (use_cache) {

...

> @@ -1137,6 +1140,7 @@ static int geneve_fill_metadata_dst(struct net_device *dev, struct sk_buff *skb)
>  {
>  	struct ip_tunnel_info *info = skb_tunnel_info(skb);
>  	struct geneve_dev *geneve = netdev_priv(dev);
> +	__u8 full_tos;
>  	__be16 sport;
>  
>  	if (ip_tunnel_info_af(info) == AF_INET) {
> @@ -1148,7 +1152,8 @@ static int geneve_fill_metadata_dst(struct net_device *dev, struct sk_buff *skb)
>  					  1, USHRT_MAX, true);
>  
>  		rt = geneve_get_v4_rt(skb, dev, gs4, &fl4, info,
> -				      geneve->cfg.info.key.tp_dst, sport);
> +				      geneve->cfg.info.key.tp_dst, sport,
> +				      &full_tos);
>  		if (IS_ERR(rt))
>  			return PTR_ERR(rt);
>  

since this one is not used