netdev - Re: [PATCH main v2 2/3] macsec: add Extended Packet Number support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5798fe5b-8424-c650-aac0-5293e1d907b4@kernel.org>
Date:   Thu, 4 Aug 2022 12:36:36 -0600
From:   David Ahern <dsahern@...nel.org>
To:     Sabrina Dubroca <sd@...asysnail.net>, ehakim@...dia.com
Cc:     netdev@...r.kernel.org, raeds@...dia.com, tariqt@...dia.com
Subject: Re: [PATCH main v2 2/3] macsec: add Extended Packet Number support

On 8/4/22 10:48 AM, Sabrina Dubroca wrote:
> Hi Emeel,
> 
> 2022-08-02, 09:18:12 +0300, ehakim@...dia.com wrote:
>> diff --git a/include/uapi/linux/if_macsec.h b/include/uapi/linux/if_macsec.h
>> index eee31cec..6edfea0a 100644
>> --- a/include/uapi/linux/if_macsec.h
>> +++ b/include/uapi/linux/if_macsec.h
>> @@ -22,6 +22,8 @@
>>  
>>  #define MACSEC_KEYID_LEN 16
>>  
>> +#define MACSEC_SALT_LEN 12
> 
> That's not in the kernel's uapi file (probably was forgotten), I
> don't think we can just add it here.
> 

can't. uapi files are synched with kernel releases, so that change would
disappear on the next sync.