netdev - RE: [PATCH main v2 2/3] macsec: add Extended Packet Number support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <IA1PR12MB635329D8F3D33A42C5977D1EAB609@IA1PR12MB6353.namprd12.prod.outlook.com>
Date:   Sun, 7 Aug 2022 07:01:10 +0000
From:   Emeel Hakim <ehakim@...dia.com>
To:     David Ahern <dsahern@...nel.org>,
        Sabrina Dubroca <sd@...asysnail.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Raed Salem <raeds@...dia.com>, Tariq Toukan <tariqt@...dia.com>
Subject: RE: [PATCH main v2 2/3] macsec: add Extended Packet Number support



> -----Original Message-----
> From: David Ahern <dsahern@...nel.org>
> Sent: Thursday, 4 August 2022 21:37
> To: Sabrina Dubroca <sd@...asysnail.net>; Emeel Hakim
> <ehakim@...dia.com>
> Cc: netdev@...r.kernel.org; Raed Salem <raeds@...dia.com>; Tariq Toukan
> <tariqt@...dia.com>
> Subject: Re: [PATCH main v2 2/3] macsec: add Extended Packet Number
> support
> 
> External email: Use caution opening links or attachments
> 
> 
> On 8/4/22 10:48 AM, Sabrina Dubroca wrote:
> > Hi Emeel,
> >
> > 2022-08-02, 09:18:12 +0300, ehakim@...dia.com wrote:
> >> diff --git a/include/uapi/linux/if_macsec.h
> >> b/include/uapi/linux/if_macsec.h index eee31cec..6edfea0a 100644
> >> --- a/include/uapi/linux/if_macsec.h
> >> +++ b/include/uapi/linux/if_macsec.h
> >> @@ -22,6 +22,8 @@
> >>
> >>  #define MACSEC_KEYID_LEN 16
> >>
> >> +#define MACSEC_SALT_LEN 12
> >
> > That's not in the kernel's uapi file (probably was forgotten), I don't
> > think we can just add it here.
> >
> 
> can't. uapi files are synched with kernel releases, so that change would
> disappear on the next sync.

ACK,
I can see that we have this define in the kernel
(not in a uapi file but as part of include/net/macsec.h), if I want to use
such a define what is the process here? do I need to move the define in
the kernel to the uapi file?
Also, in such a case Would those patches get accepted using such a define
while the kernel change is not accepted yet?