netdev - Re: [PATCH main v2 2/3] macsec: add Extended Packet Number support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <69f24a98-bd59-a0b6-5ed2-332de03b2131@gmail.com>
Date:   Sun, 7 Aug 2022 11:13:13 +0300
From:   Tariq Toukan <ttoukan.linux@...il.com>
To:     Emeel Hakim <ehakim@...dia.com>, David Ahern <dsahern@...nel.org>,
        Sabrina Dubroca <sd@...asysnail.net>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Raed Salem <raeds@...dia.com>, Tariq Toukan <tariqt@...dia.com>
Subject: Re: [PATCH main v2 2/3] macsec: add Extended Packet Number support



On 8/7/2022 10:01 AM, Emeel Hakim wrote:
> 
> 
>> -----Original Message-----
>> From: David Ahern <dsahern@...nel.org>
>> Sent: Thursday, 4 August 2022 21:37
>> To: Sabrina Dubroca <sd@...asysnail.net>; Emeel Hakim
>> <ehakim@...dia.com>
>> Cc: netdev@...r.kernel.org; Raed Salem <raeds@...dia.com>; Tariq Toukan
>> <tariqt@...dia.com>
>> Subject: Re: [PATCH main v2 2/3] macsec: add Extended Packet Number
>> support
>>
>> External email: Use caution opening links or attachments
>>
>>
>> On 8/4/22 10:48 AM, Sabrina Dubroca wrote:
>>> Hi Emeel,
>>>
>>> 2022-08-02, 09:18:12 +0300, ehakim@...dia.com wrote:
>>>> diff --git a/include/uapi/linux/if_macsec.h
>>>> b/include/uapi/linux/if_macsec.h index eee31cec..6edfea0a 100644
>>>> --- a/include/uapi/linux/if_macsec.h
>>>> +++ b/include/uapi/linux/if_macsec.h
>>>> @@ -22,6 +22,8 @@
>>>>
>>>>   #define MACSEC_KEYID_LEN 16
>>>>
>>>> +#define MACSEC_SALT_LEN 12
>>>
>>> That's not in the kernel's uapi file (probably was forgotten), I don't
>>> think we can just add it here.
>>>
>>
>> can't. uapi files are synched with kernel releases, so that change would
>> disappear on the next sync.
> 
> ACK,
> I can see that we have this define in the kernel
> (not in a uapi file but as part of include/net/macsec.h), if I want to use
> such a define what is the process here? do I need to move the define in
> the kernel to the uapi file?
> Also, in such a case Would those patches get accepted using such a define
> while the kernel change is not accepted yet?

Emeel,
Please complete the kernel changes and get them accepted first.
If a define exists in the kernel and needs to be exposed to the user, 
just move it to the uapi file and make sure it's still visible to all 
kernel usages.