lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sat,  6 Aug 2022 17:10:51 +0300
From:   Vladimir Oltean <>
        "David S. Miller" <>,
        Eric Dumazet <>,
        Jakub Kicinski <>,
        Paolo Abeni <>, Andrew Lunn <>,
        Vivien Didelot <>,
        Florian Fainelli <>,
        Vladimir Oltean <>,
        Rob Herring <>,
        Krzysztof Kozlowski <>,
        Oleksij Rempel <>,
        Christian Marangi <>,
        John Crispin <>,
        Kurt Kanzenbach <>,
        Mans Rullgard <>,
        Arun Ramadoss <>,
        Woojung Huh <>,,
        Claudiu Manoil <>,
        Alexandre Belloni <>,
        George McCollister <>,
        DENG Qingfang <>,
        Sean Wang <>,
        Landen Chao <>,
        Matthias Brugger <>,
        Hauke Mehrtens <>,
        Martin Blumenstingl <>,
        Aleksander Jan Bajkowski <>,
        Alvin Šipraga <>,
        Luiz Angelo Daros de Luca <>,
        Linus Walleij <>,
        Pawel Dembicki <>,
        Clément Léger <>,
        Geert Uytterhoeven <>,
        Russell King <>,
        Marek Behún <>,
        Marcin Wojtas <>, Marek Vasut <>,
Subject: [RFC PATCH v3 net-next 02/10] dt-bindings: net: dsa: hellcreek: add missing CPU port phy-mode/fixed-link to example

Looking at hellcreek_phylink_get_caps(), I see that depending on whether
is_100_mbits is set, speeds of 1G or of 100M will be advertised. The
de1soc_r1_pdata sets is_100_mbits to true.

The PHY modes declared in the capabilities are MII, RGMII and GMII. GMII
doesn't support 100Mbps, and as for RGMII, it would be a bit implausible
to me to support this PHY mode but limit it to only 25 MHz. So I've
settled on MII as a phy-mode in the example, and a fixed-link of

As a side note, there exists such a thing as "rev-mii", because the MII
protocol is asymmetric, and "mii" is the designation for the MAC side
(expected to be connected to a PHY), and "rev-mii" is the designation
for the PHY side (expected to be connected to a MAC). I wonder whether
"mii" or "rev-mii" should actually be used here, since this is a CPU
port and presumably connected to another MAC.

Signed-off-by: Vladimir Oltean <>
v2->v3: patch is new

 .../devicetree/bindings/net/dsa/hirschmann,hellcreek.yaml   | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/dsa/hirschmann,hellcreek.yaml b/Documentation/devicetree/bindings/net/dsa/hirschmann,hellcreek.yaml
index 228683773151..1ff44dd68a61 100644
--- a/Documentation/devicetree/bindings/net/dsa/hirschmann,hellcreek.yaml
+++ b/Documentation/devicetree/bindings/net/dsa/hirschmann,hellcreek.yaml
@@ -93,6 +93,12 @@ examples:
                     reg = <0>;
                     label = "cpu";
                     ethernet = <&gmac0>;
+                    phy-mode = "mii";
+                    fixed-link {
+                        speed = <100>;
+                        full-duplex;
+                    };
                 port@2 {

Powered by blists - more mailing lists