lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 6 Aug 2022 17:10:52 +0300 From: Vladimir Oltean <vladimir.oltean@....com> To: netdev@...r.kernel.org Cc: devicetree@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Andrew Lunn <andrew@...n.ch>, Vivien Didelot <vivien.didelot@...il.com>, Florian Fainelli <f.fainelli@...il.com>, Vladimir Oltean <olteanv@...il.com>, Rob Herring <robh+dt@...nel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Oleksij Rempel <linux@...pel-privat.de>, Christian Marangi <ansuelsmth@...il.com>, John Crispin <john@...ozen.org>, Kurt Kanzenbach <kurt@...utronix.de>, Mans Rullgard <mans@...sr.com>, Arun Ramadoss <arun.ramadoss@...rochip.com>, Woojung Huh <woojung.huh@...rochip.com>, UNGLinuxDriver@...rochip.com, Claudiu Manoil <claudiu.manoil@....com>, Alexandre Belloni <alexandre.belloni@...tlin.com>, George McCollister <george.mccollister@...il.com>, DENG Qingfang <dqfext@...il.com>, Sean Wang <sean.wang@...iatek.com>, Landen Chao <Landen.Chao@...iatek.com>, Matthias Brugger <matthias.bgg@...il.com>, Hauke Mehrtens <hauke@...ke-m.de>, Martin Blumenstingl <martin.blumenstingl@...glemail.com>, Aleksander Jan Bajkowski <olek2@...pl>, Alvin Šipraga <alsi@...g-olufsen.dk>, Luiz Angelo Daros de Luca <luizluca@...il.com>, Linus Walleij <linus.walleij@...aro.org>, Pawel Dembicki <paweldembicki@...il.com>, Clément Léger <clement.leger@...tlin.com>, Geert Uytterhoeven <geert+renesas@...der.be>, Russell King <rmk+kernel@...linux.org.uk>, Marek Behún <kabel@...nel.org>, Marcin Wojtas <mw@...ihalf.com>, Marek Vasut <marex@...x.de>, linux-renesas-soc@...r.kernel.org Subject: [RFC PATCH v3 net-next 03/10] dt-bindings: net: dsa: b53: add missing CPU port phy-mode to example Looking at b53_srab_phylink_get_caps() I get no indication of what PHY modes does port 8 support, since it is implemented circularly based on the p->mode retrieved from the device tree (and in PHY_INTERFACE_MODE_NA it reports nothing to supported_interfaces). However if I look at the b53_switch_chips[] element for BCM58XX_DEVICE_ID, I see that port 8 is the IMP port, and SRAB means the IMP port is internal to the SoC. So use phy-mode = "internal" in the example. Note that this will make b53_srab_phylink_get_caps() go through the "default" case and report PHY_INTERFACE_MODE_INTERNAL to supported_interfaces, which is probably a good thing. Signed-off-by: Vladimir Oltean <vladimir.oltean@....com> --- v2->v3: patch is new Documentation/devicetree/bindings/net/dsa/brcm,b53.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/net/dsa/brcm,b53.yaml b/Documentation/devicetree/bindings/net/dsa/brcm,b53.yaml index 23114d691d2a..2e01371b8288 100644 --- a/Documentation/devicetree/bindings/net/dsa/brcm,b53.yaml +++ b/Documentation/devicetree/bindings/net/dsa/brcm,b53.yaml @@ -254,6 +254,8 @@ examples: ethernet = <&amac2>; label = "cpu"; reg = <8>; + phy-mode = "internal"; + fixed-link { speed = <1000>; full-duplex; -- 2.34.1
Powered by blists - more mailing lists