netdev - Re: [PATCH] can: rcar_canfd: Use dev_err_probe() to simplify code and better handle -EPROBE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220808075732.gue3p4d5lhsa4sse@pengutronix.de>
Date:   Mon, 8 Aug 2022 09:57:32 +0200
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     Wolfgang Grandegger <wg@...ndegger.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-can@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH] can: rcar_canfd: Use dev_err_probe() to simplify code
 and better handle -EPROBE_DEFER

On 07.08.2022 09:52:11, Christophe JAILLET wrote:
> devm_clk_get() can return -EPROBE_DEFER, so use dev_err_probe() instead of
> dev_err() in order to be less verbose in the log.
> 
> This also saves a few LoC.
> 
> While at it, turn a "goto fail_dev;" at the beginning of the function into
> a direct return in order to avoid mixing goto and return, which looks
> spurious.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Added to can-next/testing.

Thanks,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)