lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Mon, 8 Aug 2022 10:06:32 +0200
From:   Marc Kleine-Budde <>
To:     Fedor Pchelkin <>
Cc:     Robin van der Gracht <>,
        Oleksij Rempel <>,,
        Oliver Hartkopp <>,
        "David S. Miller" <>,
        Eric Dumazet <>,
        Jakub Kicinski <>,
        Paolo Abeni <>,,,,
        Alexey Khoroshilov <>,,
        Oleksij Rempel <>
Subject: Re: [PATCH v2] can: j1939: Replace WARN_ON_ONCE with
 netdev_warn_once() in j1939_sk_queue_activate_next_locked()

On 29.07.2022 17:36:55, Fedor Pchelkin wrote:
> We should warn user-space that it is doing something wrong when trying to
> activate sessions with identical parameters but WARN_ON_ONCE macro can not
> be used here as it serves a different purpose.
> So it would be good to replace it with netdev_warn_once() message.
> Found by Linux Verification Center ( with Syzkaller.
> Fixes: 9d71dd0c7009 ("can: add support of SAE J1939 protocol")
> Signed-off-by: Fedor Pchelkin <>
> Signed-off-by: Alexey Khoroshilov <>
> Acked-by: Oleksij Rempel <>

Nitpick: You should add your S-o-b below every other tag line.

Added to linux-can with fixed indention.


Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   |  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)

Powered by blists - more mailing lists