netdev - Re: [PATCH] net_sched: cls_route: remove from list when handle is 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM0EoM=nAZJYbj-hOBxFF-3q38wMuhH11geVopYjOBv3Je4ELQ@mail.gmail.com>
Date:   Tue, 9 Aug 2022 15:11:44 -0400
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Thadeu Lima de Souza Cascardo <cascardo@...onical.com>
Cc:     netdev@...r.kernel.org, Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Pirko <jiri@...nulli.us>,
        Zhenpeng Lin <zplin@...orthwestern.edu>,
        Kamal Mostafa <kamal@...onical.com>, stable@...r.kernel.org
Subject: Re: [PATCH] net_sched: cls_route: remove from list when handle is 0

On Tue, Aug 9, 2022 at 1:06 PM Thadeu Lima de Souza Cascardo
<cascardo@...onical.com> wrote:
>
> When a route filter is replaced and the old filter has a 0 handle, the old
> one won't be removed from the hashtable, while it will still be freed.
>
> The test was there since before commit 1109c00547fc ("net: sched: RCU
> cls_route"), when a new filter was not allocated when there was an old one.
> The old filter was reused and the reinserting would only be necessary if an
> old filter was replaced. That was still wrong for the same case where the
> old handle was 0.
>
> Remove the old filter from the list independently from its handle value.
>
> This fixes CVE-2022-2588, also reported as ZDI-CAN-17440.
>
> Reported-by: Zhenpeng Lin <zplin@...orthwestern.edu>
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@...onical.com>
> Reviewed-by: Kamal Mostafa <kamal@...onical.com>
> Cc: <stable@...r.kernel.org>
> Cc: Jamal Hadi Salim <jhs@...atatu.com>

Acked-by: Jamal Hadi Salim <jhs@...atatu.com>

cheers,
jamal