| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202208110135.9PK79CPj-lkp@intel.com>
Date: Thu, 11 Aug 2022 01:08:19 +0800
From: kernel test robot <lkp@...el.com>
To: Mengyuan Lou <mengyuanlou@...-swift.com>, netdev@...r.kernel.org
Cc: kbuild-all@...ts.01.org, jiawenwu@...-swift.com,
Mengyuan Lou <mengyuanlou@...-swift.com>
Subject: Re: [PATCH net-next] net: ngbe: Add build support for ngbe
Hi Mengyuan,
I love your patch! Yet something to improve:
[auto build test ERROR on net-next/master]
url: https://github.com/intel-lab-lkp/linux/commits/Mengyuan-Lou/net-ngbe-Add-build-support-for-ngbe/20220808-174431
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git f86d1fbbe7858884d6754534a0afbb74fc30bc26
config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20220811/202208110135.9PK79CPj-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
reproduce (this is a W=1 build):
# https://github.com/intel-lab-lkp/linux/commit/b813046e2626a39496a064fb85ed44916289a4ee
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Mengyuan-Lou/net-ngbe-Add-build-support-for-ngbe/20220808-174431
git checkout b813046e2626a39496a064fb85ed44916289a4ee
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>
All errors (new ones prefixed by >>):
drivers/net/ethernet/wangxun/ngbe/ngbe_main.c: In function 'ngbe_probe':
>> drivers/net/ethernet/wangxun/ngbe/ngbe_main.c:105:42: error: 'ngbe_MAX_TX_QUEUES' undeclared (first use in this function); did you mean 'NGBE_MAX_TX_QUEUES'?
105 | ngbe_MAX_TX_QUEUES,
| ^~~~~~~~~~~~~~~~~~
| NGBE_MAX_TX_QUEUES
drivers/net/ethernet/wangxun/ngbe/ngbe_main.c:105:42: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/net/ethernet/wangxun/ngbe/ngbe_main.c:106:42: error: 'ngbe_MAX_RX_QUEUES' undeclared (first use in this function); did you mean 'NGBE_MAX_RX_QUEUES'?
106 | ngbe_MAX_RX_QUEUES);
| ^~~~~~~~~~~~~~~~~~
| NGBE_MAX_RX_QUEUES
vim +105 drivers/net/ethernet/wangxun/ngbe/ngbe_main.c
61
62 /**
63 * ngbe_probe - Device Initialization Routine
64 * @pdev: PCI device information struct
65 * @ent: entry in ngbe_pci_tbl
66 *
67 * Returns 0 on success, negative on failure
68 *
69 * ngbe_probe initializes an adapter identified by a pci_dev structure.
70 * The OS initialization, configuring of the adapter private structure,
71 * and a hardware reset occur.
72 **/
73 static int ngbe_probe(struct pci_dev *pdev,
74 const struct pci_device_id __always_unused *ent)
75 {
76 struct ngbe_adapter *adapter = NULL;
77 struct net_device *netdev;
78 int err;
79
80 err = pci_enable_device_mem(pdev);
81 if (err)
82 return err;
83
84 err = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64));
85 if (err) {
86 dev_err(&pdev->dev,
87 "No usable DMA configuration, aborting\n");
88 goto err_pci_disable_dev;
89 }
90
91 err = pci_request_selected_regions(pdev,
92 pci_select_bars(pdev, IORESOURCE_MEM),
93 ngbe_driver_name);
94 if (err) {
95 dev_err(&pdev->dev,
96 "pci_request_selected_regions failed 0x%x\n", err);
97 goto err_pci_disable_dev;
98 }
99
100 pci_enable_pcie_error_reporting(pdev);
101 pci_set_master(pdev);
102
103 netdev = devm_alloc_etherdev_mqs(&pdev->dev,
104 sizeof(struct ngbe_adapter),
> 105 ngbe_MAX_TX_QUEUES,
> 106 ngbe_MAX_RX_QUEUES);
107 if (!netdev) {
108 err = -ENOMEM;
109 goto err_pci_release_regions;
110 }
111
112 SET_NETDEV_DEV(netdev, &pdev->dev);
113
114 adapter = netdev_priv(netdev);
115 adapter->netdev = netdev;
116 adapter->pdev = pdev;
117
118 adapter->io_addr = devm_ioremap(&pdev->dev,
119 pci_resource_start(pdev, 0),
120 pci_resource_len(pdev, 0));
121 if (!adapter->io_addr) {
122 err = -EIO;
123 goto err_pci_release_regions;
124 }
125
126 netdev->features |= NETIF_F_HIGHDMA;
127
128 pci_set_drvdata(pdev, adapter);
129
130 return 0;
131
132 err_pci_release_regions:
133 pci_disable_pcie_error_reporting(pdev);
134 pci_release_selected_regions(pdev,
135 pci_select_bars(pdev, IORESOURCE_MEM));
136 err_pci_disable_dev:
137 pci_disable_device(pdev);
138 return err;
139 }
140
--
0-DAY CI Kernel Test Service
https://01.org/lkp
Powered by blists - more mailing lists