netdev - Re: [PATCH] net: sfp: use simplified HWMON_CHANNEL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 18 Aug 2022 03:21:53 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     "Russell King (Oracle)" <linux@...linux.org.uk>,
        Beniamin Sandu <beniaminsandu@...il.com>, hkallweit1@...il.com,
        davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: sfp: use simplified HWMON_CHANNEL_INFO macro

On Wed, Aug 17, 2022 at 10:19:16AM -0700, Jakub Kicinski wrote:
> On Wed, 17 Aug 2022 17:12:24 +0100 Russell King (Oracle) wrote:
> > On Wed, Aug 17, 2022 at 08:54:29AM -0700, Jakub Kicinski wrote:
> > > On Sat, 13 Aug 2022 23:46:58 +0300 Beniamin Sandu wrote:  
> > > > This makes the code look cleaner and easier to read.  
> > > 
> > > Last call for reviews..  
> > 
> > I had a quick look and couldn't see anything obviously wrong, but then
> > I'm no expert with the hwmon code.
> 
> That makes two of us, good enough! :) Thanks for taking a look.

It would of been nice to Cc: the HWMON maintainer. His input would of
been just as valuable as a PHY Maintainer.

     Andrew