lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 18 Aug 2022 09:33:44 +0800 From: Shawn Guo <shawnguo@...nel.org> To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> Cc: Wei Fang <wei.fang@....com>, davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org, s.hauer@...gutronix.de, netdev@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, kernel@...gutronix.de, festevam@...il.com, linux-imx@....com, peng.fan@....com, ping.bai@....com, sudeep.holla@....com, linux-arm-kernel@...ts.infradead.org, aisheng.dong@....com Subject: Re: [PATCH 1/3] dt-bings: net: fsl,fec: update compatible item On Mon, Jul 04, 2022 at 11:12:09AM +0200, Krzysztof Kozlowski wrote: > > diff --git a/Documentation/devicetree/bindings/net/fsl,fec.yaml b/Documentation/devicetree/bindings/net/fsl,fec.yaml > > index daa2f79a294f..6642c246951b 100644 > > --- a/Documentation/devicetree/bindings/net/fsl,fec.yaml > > +++ b/Documentation/devicetree/bindings/net/fsl,fec.yaml > > @@ -40,6 +40,10 @@ properties: > > - enum: > > - fsl,imx7d-fec > > - const: fsl,imx6sx-fec > > + - items: > > + - enum: > > + - fsl,imx8ulp-fec > > + - const: fsl,imx6ul-fec > > This is wrong. fsl,imx6ul-fec has to be followed by fsl,imx6q-fec. I > think someone made similar mistakes earlier so this is a mess. Hmm, not sure I follow this. Supposing we want to have the following compatible for i.MX8ULP FEC, why do we have to have "fsl,imx6q-fec" here? fec: ethernet@...50000 { compatible = "fsl,imx8ulp-fec", "fsl,imx6ul-fec"; ... }; Shawn > > > - items: > > - const: fsl,imx8mq-fec > > - const: fsl,imx6sx-fec
Powered by blists - more mailing lists