netdev - Re: [PATCH v3 net 05/17] ratelimit: Fix data-races in __

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220819170446.77eeb642@kernel.org>
Date:   Fri, 19 Aug 2022 17:04:46 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Kuniyuki Iwashima <kuniyu@...zon.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Kuniyuki Iwashima <kuni1840@...il.com>,
        <netdev@...r.kernel.org>
Subject: Re: [PATCH v3 net 05/17] ratelimit: Fix data-races in
 ___ratelimit().

On Thu, 18 Aug 2022 11:26:41 -0700 Kuniyuki Iwashima wrote:
> +	int interval = READ_ONCE(rs->interval);
> +	int burst = READ_ONCE(rs->burst);

Also feels a little bit like papering over an issue if we read 
two values separately.