netdev - Re: [PATCH net-next] docs: fix the table in admin-guide/sysctl/net.rst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 23 Aug 2022 18:04:54 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
        pabeni@...hat.com, Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [PATCH net-next] docs: fix the table in
 admin-guide/sysctl/net.rst

On Wed, 24 Aug 2022 10:41:43 +1000 Stephen Rothwell wrote:
> On Tue, 23 Aug 2022 16:09:06 -0700 Jakub Kicinski <kuba@...nel.org> wrote:
> >
> > The table marking length needs to be adjusted after removal
> > and reshuffling.
> > 
> > Fixes: 1202cdd66531 ("Remove DECnet support from kernel")
> > Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> > Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> > --
> > CC: Stephen Hemminger <stephen@...workplumber.org>
> 
> How about this instead so that everything lines up nicely:

Thanks for reviewing, seems like I misunderstood the warning
and fixed it accidentally :o

Should I trim the first 'Content' column to the min required length as
well? Commit 1202cdd66531 (which is in -next only) reshuffled the
entire table anyway so we won't be preserving any history by not
trimming.

> diff --git a/Documentation/admin-guide/sysctl/net.rst b/Documentation/admin-guide/sysctl/net.rst
> index 82879a9d5683..871031462e83 100644
> --- a/Documentation/admin-guide/sysctl/net.rst
> +++ b/Documentation/admin-guide/sysctl/net.rst
> @@ -31,18 +31,18 @@ see only some of them, depending on your kernel's configuration.
>  
>  Table : Subdirectories in /proc/sys/net
>  
> - ========= =================== = ========== ==================
> - Directory Content               Directory  Content
> - ========= =================== = ========== ==================
> + ========= =================== = ========= ===================
> + Directory Content               Directory Content
> + ========= =================== = ========= ===================
>   802       E802 protocol         mptcp     Multipath TCP
>   appletalk Appletalk protocol    netfilter Network Filter
> - ax25      AX25                  netrom     NET/ROM
> + ax25      AX25                  netrom    NET/ROM
>   bridge    Bridging              rose      X.25 PLP layer
>   core      General parameter     tipc      TIPC
>   ethernet  Ethernet protocol     unix      Unix domain sockets
>   ipv4      IP version 4          x25       X.25 protocol
>   ipv6      IP version 6
> - ========= =================== = ========== ==================
> + ========= =================== = ========= ===================
>  
>  1. /proc/sys/net/core - Network core options
>  ============================================
>