netdev - Re: [PATCH v1 bpf 0/4] bpf: sysctl: Fix data-races around net.core.bpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 24 Aug 2022 09:10:21 +0800
From:   dongdwdw <dongdwdw@...ux.vnet.ibm.com>
To:     Kuniyuki Iwashima <kuniyu@...zon.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>
Cc:     Kuniyuki Iwashima <kuni1840@...il.com>, bpf@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH v1 bpf 0/4] bpf: sysctl: Fix data-races around
 net.core.bpf_XXX.

This patch set got my attention because I found some issue about 
bpf_jit_harden.
But after reading your patches, I did not get what the problem you are 
trying resolve and what is improved.
You said there is a data race, what is that? Can you please show how 
does this happen? What is the influence?
Would you please let me know these background info?

On 2022/8/18 12:23, Kuniyuki Iwashima wrote:
> This series split from [0] fixes data-races around 4 bpf knobs
> in net_core_table.
>
> [0]: https://lore.kernel.org/netdev/20220818035227.81567-1-kuniyu@amazon.com/
>
>
> Kuniyuki Iwashima (4):
>    bpf: Fix data-races around bpf_jit_enable.
>    bpf: Fix data-races around bpf_jit_harden.
>    bpf: Fix data-races around bpf_jit_kallsyms.
>    bpf: Fix a data-race around bpf_jit_limit.
>
>   arch/arm/net/bpf_jit_32.c        |  2 +-
>   arch/arm64/net/bpf_jit_comp.c    |  2 +-
>   arch/mips/net/bpf_jit_comp.c     |  2 +-
>   arch/powerpc/net/bpf_jit_comp.c  |  5 +++--
>   arch/riscv/net/bpf_jit_core.c    |  2 +-
>   arch/s390/net/bpf_jit_comp.c     |  2 +-
>   arch/sparc/net/bpf_jit_comp_32.c |  5 +++--
>   arch/sparc/net/bpf_jit_comp_64.c |  5 +++--
>   arch/x86/net/bpf_jit_comp.c      |  2 +-
>   arch/x86/net/bpf_jit_comp32.c    |  2 +-
>   include/linux/filter.h           | 16 ++++++++++------
>   kernel/bpf/core.c                |  2 +-
>   net/core/sysctl_net_core.c       |  4 ++--
>   13 files changed, 29 insertions(+), 22 deletions(-)
>