netdev - Re: [PATCH net-next] net: ftmac100: add an opportunity to get ethaddr from the platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YwZEmo9sVds8CJdD@lunn.ch>
Date:   Wed, 24 Aug 2022 17:32:42 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Sergei Antonov <saproj@...il.com>
Cc:     netdev@...r.kernel.org, olteanv@...il.com, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        tangbin@...s.chinamobile.com, caizhichao@...ong.com
Subject: Re: [PATCH net-next] net: ftmac100: add an opportunity to get
 ethaddr from the platform

On Wed, Aug 24, 2022 at 06:17:24PM +0300, Sergei Antonov wrote:
> This driver always generated a random ethernet address. Leave it as a
> fallback solution, but add a call to platform_get_ethdev_address().
> Handle EPROBE_DEFER returned from platform_get_ethdev_address() to
> retry when EEPROM is ready.

Hi Sergei

This is version 2 correct, you added -EPROBE_DEFER handling?

Please add a v2 into the Subject "[PATCH v2 net-next]" so we can keep
track of the different versions.

Also, list briefly under the --- what you changed with each version.

It is worth reading:

https://www.kernel.org/doc/html/latest/process/submitting-patches.html

and

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html#netdev-faq

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew