netdev - Re: [PATCH net-next] net: ftmac100: add an opportunity to get ethaddr from the platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABikg9z4n75TdoUd-9Q-W2Ahr5-yTszKVxq09uHB9kyhQkhTng@mail.gmail.com>
Date:   Wed, 24 Aug 2022 18:40:44 +0300
From:   Sergei Antonov <saproj@...il.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     netdev@...r.kernel.org, Vladimir Oltean <olteanv@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, tangbin@...s.chinamobile.com,
        caizhichao@...ong.com
Subject: Re: [PATCH net-next] net: ftmac100: add an opportunity to get ethaddr
 from the platform

On Wed, 24 Aug 2022 at 18:32, Andrew Lunn <andrew@...n.ch> wrote:
>
> On Wed, Aug 24, 2022 at 06:17:24PM +0300, Sergei Antonov wrote:
> > This driver always generated a random ethernet address. Leave it as a
> > fallback solution, but add a call to platform_get_ethdev_address().
> > Handle EPROBE_DEFER returned from platform_get_ethdev_address() to
> > retry when EEPROM is ready.
>
> Hi Sergei
>
> This is version 2 correct, you added -EPROBE_DEFER handling?

No, that's v1 for drivers/net/ethernet/moxa/ftmac100.c driver and
-EPROBE_DEFER handling is present from the start.
I previously submitted an analogous patch for another driver:
drivers/net/ethernet/moxa/moxart_ether.c. And yes, there were v1 and
v2.