lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 29 Aug 2022 14:13:24 +0200 From: Vlad Buslov <vladbu@...dia.com> To: <davem@...emloft.net>, <jiri@...nulli.us>, <kuba@...nel.org> CC: <netdev@...r.kernel.org>, <maord@...dia.com>, <saeedm@...dia.com>, <leon@...nel.org>, <roid@...dia.com>, <jiri@...dia.com>, Vlad Buslov <vladbu@...dia.com> Subject: [PATCH net-next] Revert "net: devlink: add RNLT lock assertion to devlink_compat_switch_id_get()" This reverts commit 6005a8aecee8afeba826295321a612ab485c230e. The assertion was intentionally removed in commit 043b8413e8c0 ("net: devlink: remove redundant rtnl lock assert") and, contrary what is described in the commit message, the comment reflects that: "Caller must hold RTNL mutex or reference to dev...". Signed-off-by: Vlad Buslov <vladbu@...dia.com> --- net/core/devlink.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/core/devlink.c b/net/core/devlink.c index 2afbeb6eca67..0f7078db1280 100644 --- a/net/core/devlink.c +++ b/net/core/devlink.c @@ -12505,8 +12505,6 @@ int devlink_compat_switch_id_get(struct net_device *dev, * devlink_port instance cannot disappear in the middle. No need to take * any devlink lock as only permanent values are accessed. */ - ASSERT_RTNL(); - devlink_port = netdev_to_devlink_port(dev); if (!devlink_port || !devlink_port->switch_port) return -EOPNOTSUPP; -- 2.36.1
Powered by blists - more mailing lists