netdev - Re: [PATCH net-next] Revert "net: devlink: add RNLT lock assertion to devlink_compat_switch_id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YwyuoJI08MVhX2YX@unreal>
Date:   Mon, 29 Aug 2022 15:18:40 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Vlad Buslov <vladbu@...dia.com>
Cc:     davem@...emloft.net, jiri@...nulli.us, kuba@...nel.org,
        netdev@...r.kernel.org, maord@...dia.com, saeedm@...dia.com,
        roid@...dia.com, jiri@...dia.com
Subject: Re: [PATCH net-next] Revert "net: devlink: add RNLT lock assertion
 to devlink_compat_switch_id_get()"

On Mon, Aug 29, 2022 at 02:13:24PM +0200, Vlad Buslov wrote:
> This reverts commit 6005a8aecee8afeba826295321a612ab485c230e.
> 
> The assertion was intentionally removed in commit 043b8413e8c0 ("net:
> devlink: remove redundant rtnl lock assert") and, contrary what is
> described in the commit message, the comment reflects that: "Caller must
> hold RTNL mutex or reference to dev...".
> 
> Signed-off-by: Vlad Buslov <vladbu@...dia.com>
> ---
>  net/core/devlink.c | 2 --
>  1 file changed, 2 deletions(-)
> 

Thanks,
Tested-by: Leon Romanovsky <leonro@...dia.com>