netdev - Re: [PATCH net-next] net/sched: cls_api: remove redundant 0 check in tcf_qevent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220831123014.18456fa9@kernel.org>
Date:   Wed, 31 Aug 2022 12:30:14 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Zhengchao Shao <shaozhengchao@...wei.com>
Cc:     <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <davem@...emloft.net>, <edumazet@...gle.com>, <pabeni@...hat.com>,
        <jhs@...atatu.com>, <xiyou.wangcong@...il.com>, <jiri@...nulli.us>,
        <weiyongjun1@...wei.com>, <yuehaibing@...wei.com>
Subject: Re: [PATCH net-next] net/sched: cls_api: remove redundant 0 check
 in tcf_qevent_init()

On Mon, 29 Aug 2022 15:17:20 +0800 Zhengchao Shao wrote:
> tcf_qevent_parse_block_index() has been checked the value of block_index.

Please rephrase this:

  tcf_qevent_parse_block_index() never returns a zero block_index.

Took me a while to figure out what you mean.

> Therefore, it is unnecessary to check the value of block_index in
> tcf_qevent_init().