netdev - Re: [PATCH net 3/3] ice: Add set_termios tty operations handle to GNSS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <28e460f1-f130-7bf1-ad66-3b7080726b3d@intel.com>
Date:   Fri, 2 Sep 2022 09:55:30 -0700
From:   Tony Nguyen <anthony.l.nguyen@...el.com>
To:     Jakub Kicinski <kuba@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     <davem@...emloft.net>, <pabeni@...hat.com>, <edumazet@...gle.com>,
        "Michal Michalik" <michal.michalik@...el.com>,
        <netdev@...r.kernel.org>, <richardcochran@...il.com>,
        Gurucharan <gurucharanx.g@...el.com>,
        Jiri Slaby <jirislaby@...nel.org>,
        Johan Hovold <johan@...nel.org>
Subject: Re: [PATCH net 3/3] ice: Add set_termios tty operations handle to
 GNSS



On 9/1/2022 1:18 PM, Jakub Kicinski wrote:
> On Thu, 1 Sep 2022 07:46:23 +0200 Greg Kroah-Hartman wrote:
>>> Please CC GNSS and TTY maintainers on the patches relating to
>>> the TTY/GNSS channel going forward.
>>>
>>> CC: Greg, Jiri, Johan
>>>
>>> We'll pull in a day or two if there are no objections.
>>
>> Please see above, I'd like to know what is really failing here and why
>> as forcing drivers to have "empty" functions like this is not good and
>> never the goal.
> 
> Thanks for a prompt look!
> 
> Tony, I presume you may want to sidetrack this patch for now and ship
> the rest so lemme toss this version of the series.

Hi Jakub,

Yes, I'll drop this one and send the others.

I'm working internally to get responses to the other questions/comments 
for this as well.

Thanks,
Tony