netdev - Re: [PATCH v3: net-next 4/4] net: dsa: microchip: add regmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <353a35c2-477e-2183-109b-e2a08aeab66d@smile.fr>
Date:   Fri, 2 Sep 2022 19:20:04 +0200
From:   Romain Naour <romain.naour@...le.fr>
To:     Arun.Ramadoss@...rochip.com, netdev@...r.kernel.org
Cc:     olteanv@...il.com, andrew@...n.ch, UNGLinuxDriver@...rochip.com,
        vivien.didelot@...il.com, f.fainelli@...il.com, kuba@...nel.org,
        pabeni@...hat.com, edumazet@...gle.com, Woojung.Huh@...rochip.com,
        romain.naour@....com, davem@...emloft.net
Subject: Re: [PATCH v3: net-next 4/4] net: dsa: microchip: add regmap_range
 for KSZ9896 chip

Hi Arun,

Le 02/09/2022 à 15:33, Arun.Ramadoss@...rochip.com a écrit :
> On Fri, 2022-09-02 at 12:16 +0200, Romain Naour wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you
>> know the content is safe
>>
>> From: Romain Naour <romain.naour@....com>
>>
>> Add register validation for KSZ9896.
>>
> 
> Hi Oleksij,
> Do we have any support for regular expression support for the
> regmap_reg_range, since all the ports have same register configuration
> except the port number in the msb. Becaue If I need to add regmap
> validation for lan937x which has 5 variant with port count from 4 to 8
> it will increase the file size. Do we need to move the register map to
> other file or adding in ksz_common.c itself is fine.
> 

Notice that the cpu port is special, it has two extra registers (XMII Port Control)

regmap_reg_range(0x6300, 0x6301)

Best regards,
Romain


>> +
>> +       /* port 5 */
>> +       regmap_reg_range(0x5000, 0x5001),
>> +       regmap_reg_range(0x5013, 0x5013),
>> +       regmap_reg_range(0x5017, 0x5017),
>> +       regmap_reg_range(0x501b, 0x501b),
>> +       regmap_reg_range(0x501f, 0x5020),
>> +       regmap_reg_range(0x5030, 0x5030),
>> +       regmap_reg_range(0x5100, 0x5115),
>> +       regmap_reg_range(0x511a, 0x511f),
>> +       regmap_reg_range(0x5122, 0x5127),
>> +       regmap_reg_range(0x512a, 0x512b),
>> +       regmap_reg_range(0x5136, 0x5139),
>> +       regmap_reg_range(0x513e, 0x513f),
>> +       regmap_reg_range(0x5400, 0x5401),
>> +       regmap_reg_range(0x5403, 0x5403),
>> +       regmap_reg_range(0x5410, 0x5417),
>> +       regmap_reg_range(0x5420, 0x5423),
>> +       regmap_reg_range(0x5500, 0x5507),
>> +       regmap_reg_range(0x5600, 0x5612),
>> +       regmap_reg_range(0x5800, 0x580f),
>> +       regmap_reg_range(0x5820, 0x5827),
>> +       regmap_reg_range(0x5830, 0x5837),
>> +       regmap_reg_range(0x5840, 0x584b),
>> +       regmap_reg_range(0x5900, 0x5907),
>> +       regmap_reg_range(0x5914, 0x5915),
>> +       regmap_reg_range(0x5a00, 0x5a03),
>> +       regmap_reg_range(0x5a04, 0x5a07),
>> +       regmap_reg_range(0x5b00, 0x5b01),
>> +       regmap_reg_range(0x5b04, 0x5b04),
>> +
>> +       /* port 6 */
>> +       regmap_reg_range(0x6000, 0x6001),
>> +       regmap_reg_range(0x6013, 0x6013),
>> +       regmap_reg_range(0x6017, 0x6017),
>> +       regmap_reg_range(0x601b, 0x601b),
>> +       regmap_reg_range(0x601f, 0x6020),
>> +       regmap_reg_range(0x6030, 0x6030),
>> +       regmap_reg_range(0x6100, 0x6115),
>> +       regmap_reg_range(0x611a, 0x611f),
>> +       regmap_reg_range(0x6122, 0x6127),
>> +       regmap_reg_range(0x612a, 0x612b),
>> +       regmap_reg_range(0x6136, 0x6139),
>> +       regmap_reg_range(0x613e, 0x613f),
>> +       regmap_reg_range(0x6300, 0x6301),
>> +       regmap_reg_range(0x6400, 0x6401),
>> +       regmap_reg_range(0x6403, 0x6403),
>> +       regmap_reg_range(0x6410, 0x6417),
>> +       regmap_reg_range(0x6420, 0x6423),
>> +       regmap_reg_range(0x6500, 0x6507),
>> +       regmap_reg_range(0x6600, 0x6612),
>> +       regmap_reg_range(0x6800, 0x680f),
>> +       regmap_reg_range(0x6820, 0x6827),
>> +       regmap_reg_range(0x6830, 0x6837),
>> +       regmap_reg_range(0x6840, 0x684b),
>> +       regmap_reg_range(0x6900, 0x6907),
>> +       regmap_reg_range(0x6914, 0x6915),
>> +       regmap_reg_range(0x6a00, 0x6a03),
>> +       regmap_reg_range(0x6a04, 0x6a07),
>> +       regmap_reg_range(0x6b00, 0x6b01),
>> +       regmap_reg_range(0x6b04, 0x6b04),
>> +};
>> +