netdev - Re: [PATCH v3: net-next 2/4] net: dsa: microchip: add KSZ9896 to KSZ9477 I2C driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0e2eafc1-4af8-15c0-f587-eddb454c8754@smile.fr>
Date:   Fri, 2 Sep 2022 19:23:53 +0200
From:   Romain Naour <romain.naour@...le.fr>
To:     Arun.Ramadoss@...rochip.com, netdev@...r.kernel.org
Cc:     olteanv@...il.com, andrew@...n.ch, UNGLinuxDriver@...rochip.com,
        vivien.didelot@...il.com, f.fainelli@...il.com, kuba@...nel.org,
        pabeni@...hat.com, edumazet@...gle.com, Woojung.Huh@...rochip.com,
        romain.naour@....com, davem@...emloft.net
Subject: Re: [PATCH v3: net-next 2/4] net: dsa: microchip: add KSZ9896 to
 KSZ9477 I2C driver

Hi Arun,

Le 02/09/2022 à 15:39, Arun.Ramadoss@...rochip.com a écrit :
> On Fri, 2022-09-02 at 12:16 +0200, Romain Naour wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you
>> know the content is safe
>>
>> From: Romain Naour <romain.naour@....com>
>>
>> Add support for the KSZ9896 6-port Gigabit Ethernet Switch to the
>> ksz9477 driver. The KSZ9896 supports both SPI (already in) and I2C.
>>
>> Signed-off-by: Romain Naour <romain.naour@....com>
>> ---
>> The KSZ9896 support i2c interface, it seems safe to enable as is but
>> runtime testing is really needed (my KSZ9896 is wired with spi).
>>
>> v2: remove duplicated SoB line
>> ---
>>  drivers/net/dsa/microchip/ksz9477_i2c.c | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/net/dsa/microchip/ksz9477_i2c.c
>> b/drivers/net/dsa/microchip/ksz9477_i2c.c
>> index 99966514d444..8fbc122e3384 100644
>> --- a/drivers/net/dsa/microchip/ksz9477_i2c.c
>> +++ b/drivers/net/dsa/microchip/ksz9477_i2c.c
>> @@ -91,6 +91,10 @@ static const struct of_device_id ksz9477_dt_ids[]
>> = {
>>                 .compatible = "microchip,ksz9477",
>>                 .data = &ksz_switch_chips[KSZ9477]
>>         },
>> +       {
>> +               .compatible = "microchip,ksz9896",
>> +               .data = &ksz_switch_chips[KSZ9896]
>> +       },
> 
> Do we need to add the compatible in ksz_spi interface as well, since
> ksz9896 supports both i2c and spi interface.

That's what the first patch does.

Thanks for your review.

Best regards,
Romain


> 
>>         {
>>                 .compatible = "microchip,ksz9897",
>>                 .data = &ksz_switch_chips[KSZ9897]
>> --
>> 2.34.3
>>