netdev - RE: [PATCH net 3/3] ice: Add set_termios tty operations handle to GNSS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 5 Sep 2022 19:47:14 +0000
From:   "Michalik, Michal" <michal.michalik@...el.com>
To:     Jiri Slaby <jirislaby@...nel.org>, Johan Hovold <johan@...nel.org>,
        "Jakub Kicinski" <kuba@...nel.org>,
        "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "richardcochran@...il.com" <richardcochran@...il.com>,
        "G, GurucharanX" <gurucharanx.g@...el.com>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>
Subject: RE: [PATCH net 3/3] ice: Add set_termios tty operations handle to
 GNSS

Hi Jiri,

Agree with you, we will work on aligning to the GNSS subsystem if that would be
possible in our implementation according to Johan suggestion.

We will also make sure to make our code less "interesting", when comes to constructs.

Thanks a lot!

BR,
M^2

> -----Original Message-----
> From: Jiri Slaby <jirislaby@...nel.org> 
> Sent: Friday, September 2, 2022 12:47 PM
> To: Johan Hovold <johan@...nel.org>; Jakub Kicinski <kuba@...nel.org>; Nguyen, Anthony L <anthony.l.nguyen@...el.com>
> Cc: davem@...emloft.net; pabeni@...hat.com; edumazet@...gle.com; Michalik, Michal <michal.michalik@...el.com>; netdev@...r.kernel.org; richardcochran@...il.com; G, GurucharanX <gurucharanx.g@...el.com>; Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Subject: Re: [PATCH net 3/3] ice: Add set_termios tty operations handle to GNSS
> 
> On 02. 09. 22, 9:42, Jiri Slaby wrote:
> > On 01. 09. 22, 8:44, Johan Hovold wrote:
> >> Looks like this was merged in 5.18 with 43113ff73453 ("ice: add TTY for
> >> GNSS module for E810T device") without any input from people familiar
> >> with tty either.
> > 
> > FWIW doesn't it crash in ice_gnss_tty_write() on parallel tty opens due to:
> >           tty->driver_data = NULL;
> > in ice_gnss_tty_open()?
> 
> Oh, the driver checks for tty->driver_data in every operation (gee). So 
> at least that crash is mitigated. The userspace will "only" receive 
> EFAULT from time to time.
> 
> > There are many "interesting" constructs in the driver...
> 
> The checks belong among this "interesting" constructs too.
> 
> > thanks,-- 
> js
> suse labs
>