netdev - Re: [PATCH net 3/3] ice: Add set_termios tty operations handle to GNSS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YxbliLlS9YU6eKMn@kroah.com>
Date:   Tue, 6 Sep 2022 08:15:36 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     "Michalik, Michal" <michal.michalik@...el.com>
Cc:     Jakub Kicinski <kuba@...nel.org>,
        "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "richardcochran@...il.com" <richardcochran@...il.com>,
        "G, GurucharanX" <gurucharanx.g@...el.com>,
        Jiri Slaby <jirislaby@...nel.org>,
        Johan Hovold <johan@...nel.org>
Subject: Re: [PATCH net 3/3] ice: Add set_termios tty operations handle to
 GNSS

On Mon, Sep 05, 2022 at 07:32:44PM +0000, Michalik, Michal wrote:
> Hello Greg,
> 
> Much thanks for a feedback. Please excuse me for delayed answer, we tried to collect all
> the required information before returning to you - but we are still working on it.
> 
> Best regards,
> M^2
> 
> > 
> > -----Original Message-----
> > From: Greg Kroah-Hartman <gregkh@...uxfoundation.org> 
> > Sent: Thursday, September 1, 2022 7:46 AM
> > To: Jakub Kicinski <kuba@...nel.org>
> > Cc: Nguyen, Anthony L <anthony.l.nguyen@...el.com>; davem@...emloft.net; pabeni@...hat.com; edumazet@...gle.com; Michalik, Michal <michal.michalik@...el.com>; netdev@...r.kernel.org; richardcochran@...il.com; G, GurucharanX <gurucharanx.g@...el.com>; Jiri Slaby <jirislaby@...nel.org>; Johan Hovold <johan@...nel.org>
> > Subject: Re: [PATCH net 3/3] ice: Add set_termios tty operations handle to GNSS
> > 
> > On Wed, Aug 31, 2022 at 02:54:39PM -0700, Jakub Kicinski wrote:
> > > On Mon, 29 Aug 2022 15:00:49 -0700 Tony Nguyen wrote:
> > > > From: Michal Michalik <michal.michalik@...el.com>
> > > > 
> > > > Some third party tools (ex. ubxtool) try to change GNSS TTY parameters
> > > > (ex. speed). While being optional implementation, without set_termios
> > > > handle this operation fails and prevents those third party tools from
> > > > working.
> > 
> > What tools are "blocked" by this?  And what is the problem they have
> > with just the default happening here?  You are now doing nothing, while
> > if you do not have the callback, at least a basic "yes, we accepted
> > these values" happens which was intended for userspace to not know that
> > there was a problem here.
> > 
> 
> As I stated in the commit message, the example tool is ubxtool - while trying to
> connect to the GPS module the error appreared:
> Traceback (most recent call last):
> 
> 	  File "/usr/local/bin/ubxtool", line 378, in <module>
> 		io_handle = gps.gps_io(
> 	  File "/usr/local/lib/python3.9/site-packages/gps/gps.py", line 309, in __init__
> 		self.ser = Serial.Serial(
> 	  File "/usr/local/lib/python3.9/site-packages/serial/serialutil.py", line 244, in __init__
> 		self.open()
> 	  File "/usr/local/lib/python3.9/site-packages/serial/serialposix.py", line 332, in open
> 		self._reconfigure_port(force_update=True)
> 	  File "/usr/local/lib/python3.9/site-packages/serial/serialposix.py", line 517, in _reconfigure_port
> 		termios.tcsetattr(
> 	termios.error: (22, 'Invalid argument')
> 	
> Adding this empty function solved the problem.

That seems very wrong, please work to fix this by NOT having an empty
function like this as it should not be required.

thanks,

greg k-h