netdev - Re: [PATCH net-next v4 0/6] net: dsa: mv88e6xxx: qca8k: rmon: Add RMU support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <951d7336-ab24-1fc3-bb63-837145a7f043@gmail.com>
Date:   Tue, 6 Sep 2022 11:45:41 +0200
From:   Mattias Forsblad <mattias.forsblad@...il.com>
To:     Marek Behún <kabel@...nel.org>
Cc:     netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next v4 0/6] net: dsa: mv88e6xxx: qca8k: rmon: Add RMU
 support

On 2022-09-06 10:07, Marek Behún wrote:
> Nitpick: in subject, the order of components separated by ':' infers
> hierarchy, so your subject
>   net: dsa: mv88e6xxx: qca8k: rmon: Add RMU support
> means:
>   component net
>     subcompoment dsa
>       subcomponent mv88e6xxx
>         subcomponent qca8k (this is wrong since qca8k is separate
>                             driver, not a subcomponent of mv88e6xxx)
> 
> You should use ',' to separate mv88e6xxx and qca8k, something like
>   net: dsa: mv88e6xxx, qca8k: rmon: Add RMU support
> 
> Since this is not an actual patch, but instead a cover letter only,
> it's not a problem (at least not for me). But please try not to do it
> in actual patches.
> 
> Marek

Ah, ok I see your point. Thanks.

/Mattias