netdev - Re: [PATCH net] sch_sfb: Also store skb len before calling child enqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YxjUmCi2UvA8/vRs@pop-os.localdomain>
Date:   Wed, 7 Sep 2022 10:27:52 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Toke Høiland-Jørgensen <toke@...e.dk>
Cc:     Jamal Hadi Salim <jhs@...atatu.com>, Jiri Pirko <jiri@...nulli.us>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net] sch_sfb: Also store skb len before calling child
 enqueue

On Mon, Sep 05, 2022 at 09:21:36PM +0200, Toke Høiland-Jørgensen wrote:
> Cong Wang noticed that the previous fix for sch_sfb accessing the queued
> skb after enqueueing it to a child qdisc was incomplete: the SFB enqueue
> function was also calling qdisc_qstats_backlog_inc() after enqueue, which
> reads the pkt len from the skb cb field. Fix this by also storing the skb
> len, and using the stored value to increment the backlog after enqueueing.
> 
> Fixes: 9efd23297cca ("sch_sfb: Don't assume the skb is still around after enqueueing to child")
> Signed-off-by: Toke Høiland-Jørgensen <toke@...e.dk>

Acked-by: Cong Wang <cong.wang@...edance.com>

Thanks.