netdev - Re: [PATCH net] sch_sfb: Also store skb len before calling child enqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <166262941571.17191.4142047101598818384.git-patchwork-notify@kernel.org>
Date:   Thu, 08 Sep 2022 09:30:15 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Toke Høiland-Jørgensen <toke@...e.dk>@ci.codeaurora.org
Cc:     jhs@...atatu.com, xiyou.wangcong@...il.com, jiri@...nulli.us,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH net] sch_sfb: Also store skb len before calling child enqueue

Hello:

This patch was applied to netdev/net.git (master)
by Paolo Abeni <pabeni@...hat.com>:

On Mon,  5 Sep 2022 21:21:36 +0200 you wrote:
> Cong Wang noticed that the previous fix for sch_sfb accessing the queued
> skb after enqueueing it to a child qdisc was incomplete: the SFB enqueue
> function was also calling qdisc_qstats_backlog_inc() after enqueue, which
> reads the pkt len from the skb cb field. Fix this by also storing the skb
> len, and using the stored value to increment the backlog after enqueueing.
> 
> Fixes: 9efd23297cca ("sch_sfb: Don't assume the skb is still around after enqueueing to child")
> Signed-off-by: Toke Høiland-Jørgensen <toke@...e.dk>
> 
> [...]

Here is the summary with links:
  - [net] sch_sfb: Also store skb len before calling child enqueue
    https://git.kernel.org/netdev/net/c/2f09707d0c97

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html