[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20220909080631.6941a770@hermes.local>
Date: Fri, 9 Sep 2022 08:06:31 -0700
From: Stephen Hemminger <stephen@...workplumber.org>
To: Daniel Machon <daniel.machon@...rochip.com>
Cc: <netdev@...r.kernel.org>, <Allan.Nielsen@...rochip.com>,
<UNGLinuxDriver@...rochip.com>, <maxime.chevallier@...tlin.com>,
<vladimir.oltean@....com>, <petrm@...dia.com>, <kuba@...nel.org>,
<vinicius.gomes@...el.com>, <thomas.petazzoni@...tlin.com>
Subject: Re: [RFC PATCH iproute2-next 2/2] dcb: add new subcommand for
apptrust object
On Fri, 9 Sep 2022 12:37:01 +0200
Daniel Machon <daniel.machon@...rochip.com> wrote:
> } else if (matches(*argv, "app") == 0) {
> return dcb_cmd_app(dcb, argc - 1, argv + 1);
> + } else if (matches(*argv, "apptrust") == 0) {
> + return dcb_cmd_apptrust(dcb, argc - 1, argv + 1);
> } else if (matches(*argv, "buffer") == 0) {
Yet another example of why matches() is bad.
Perhaps this should be named trust instead of apptrust.
Powered by blists - more mailing lists