netdev - Re: [RFC PATCH iproute2-next 2/2] dcb: add new subcommand for apptrust object

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yx7PRgPKy0ruMDSE@DEN-LT-70577>
Date:   Mon, 12 Sep 2022 06:09:33 +0000
From:   <Daniel.Machon@...rochip.com>
To:     <stephen@...workplumber.org>
CC:     <netdev@...r.kernel.org>, <Allan.Nielsen@...rochip.com>,
        <UNGLinuxDriver@...rochip.com>, <maxime.chevallier@...tlin.com>,
        <vladimir.oltean@....com>, <petrm@...dia.com>, <kuba@...nel.org>,
        <vinicius.gomes@...el.com>, <thomas.petazzoni@...tlin.com>
Subject: Re: [RFC PATCH iproute2-next 2/2] dcb: add new subcommand for
 apptrust object

Den Fri, Sep 09, 2022 at 08:06:31AM -0700 skrev Stephen Hemminger:
> [You don't often get email from stephen@...workplumber.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Fri, 9 Sep 2022 12:37:01 +0200
> Daniel Machon <daniel.machon@...rochip.com> wrote:
> 
> >       } else if (matches(*argv, "app") == 0) {
> >               return dcb_cmd_app(dcb, argc - 1, argv + 1);
> > +     } else if (matches(*argv, "apptrust") == 0) {
> > +             return dcb_cmd_apptrust(dcb, argc - 1, argv + 1);
> >       } else if (matches(*argv, "buffer") == 0) {
> 
> Yet another example of why matches() is bad.
> 
> Perhaps this should be named trust instead of apptrust.

Hah, that slipped my mind.

Obviously this wont do. Will have to come up with some different naming 
in an eventual non-RFC patch.