netdev - Re: [PATCH 1/2] Revert "net: fec: Use a spinlock to guard `fep->ptp_clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220912123822.f6iulx4hw2dm7fnt@pengutronix.de>
Date:   Mon, 12 Sep 2022 14:38:22 +0200
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Bence Csókás <bence98@....bme.hu>
Cc:     Andrew Lunn <andrew@...n.ch>, netdev@...r.kernel.org,
        Richard Cochran <richardcochran@...il.com>,
        Csókás Bence <csokas.bence@...lan.hu>,
        kernel@...gutronix.de, Jakub Kicinski <kuba@...nel.org>,
        Francesco Dolcini <francesco.dolcini@...adex.com>,
        "David S . Miller" <davem@...emloft.net>,
        Guenter Roeck <linux@...ck-us.net>
Subject: Re: [PATCH 1/2] Revert "net: fec: Use a spinlock to guard
 `fep->ptp_clk_on`"

On 12.09.2022 12:38:18, Marc Kleine-Budde wrote:
> On 12.09.2022 07:31:04, Bence Csókás wrote:
> > From: Csókás Bence <csokas.bence@...lan.hu>
> > 
> > `clk_prepare_enable()` gets called in atomic context (holding a spinlock),
> > which may sleep, causing a BUG on certain platforms.
> > 
> > This reverts commit b353b241f1eb9b6265358ffbe2632fdcb563354f.
> > 
> > Reported-by: Marc Kleine-Budde <mkl@...gutronix.de>
> > Link: https://lore.kernel.org/all/20220907143915.5w65kainpykfobte@pengutronix.de/
> > Signed-off-by: Csókás Bence <csokas.bence@...lan.hu>
> 
> This is not a 100% revert.

Better use the Francesco Dolcini's revert series

| https://lore.kernel.org/all/20220912070143.98153-1-francesco.dolcini@toradex.com/

instead.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)