netdev - Re: [PATCH v3 1/1] wcn36xx: Add RX frame SNR as a source of system entropy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAMZdPi_+zQe41xSx+LHj_FDeHu7rs=TEgbWGBaMxcoSrOvXLRQ@mail.gmail.com>
Date:   Fri, 16 Sep 2022 18:42:08 +0200
From:   Loic Poulain <loic.poulain@...aro.org>
To:     "Bryan O'Donoghue" <bryan.odonoghue@...aro.org>
Cc:     "Jason A . Donenfeld" <Jason@...c4.com>, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, kvalo@...nel.org,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        pabeni@...hat.com, wcn36xx@...ts.infradead.org
Subject: Re: [PATCH v3 1/1] wcn36xx: Add RX frame SNR as a source of system entropy

On Thu, 15 Sept 2022 at 02:41, Bryan O'Donoghue <bryan.odonoghue@...aro.org>
wrote:
>
> The signal-to-noise-ratio SNR is returned by the wcn36xx firmware for each
> received frame. SNR represents all of the unwanted interference signal
> after filtering out the fundamental frequency and harmonics of the
> frequency.
>
> Noise can come from various electromagnetic sources, from temperature
> affecting the performance hardware components or quantization effects
> converting from analog to digital domains.
>
> The SNR value returned by the WiFi firmware then is a good source of
> entropy.
>
> Other WiFi drivers offer up the noise component of the FFT as an entropy
> source for the random pool e.g.
>
> commit 2aa56cca3571 ("ath9k: Mix the received FFT bins to the random
pool")
>
> I attended Jason's talk on sources of randomness at Plumbers and it
> occurred to me that SNR is a reasonable candidate to add.
>
> Cc: Jason A. Donenfeld <Jason@...c4.com>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>

Acked-by: Loic Poulain <loic.poulain@...aro.org>