netdev - Re: [net-next v2 1/3] seg6: add netlink_ext_ack support in parsing SRv6 behavior attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <75585c26-b4bc-8004-dc45-cedba6b8b392@kernel.org>
Date:   Fri, 16 Sep 2022 10:43:01 -0600
From:   David Ahern <dsahern@...nel.org>
To:     Andrea Mayer <andrea.mayer@...roma2.it>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        Shuah Khan <shuah@...nel.org>, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, linux-kselftest@...r.kernel.org,
        bpf@...r.kernel.org
Cc:     Stefano Salsano <stefano.salsano@...roma2.it>,
        Paolo Lungaroni <paolo.lungaroni@...roma2.it>,
        Ahmed Abdelsalam <ahabdels.dev@...il.com>
Subject: Re: [net-next v2 1/3] seg6: add netlink_ext_ack support in parsing
 SRv6 behavior attributes

On 9/12/22 11:16 AM, Andrea Mayer wrote:
> An SRv6 behavior instance can be set up using mandatory and/or optional
> attributes.
> In the setup phase, each supplied attribute is parsed and processed. If
> the parsing operation fails, the creation of the behavior instance stops
> and an error number/code is reported to the user.  In many cases, it is
> challenging for the user to figure out exactly what happened by relying
> only on the error code.
> 
> For this reason, we add the support for netlink_ext_ack in parsing SRv6
> behavior attributes. In this way, when an SRv6 behavior attribute is
> parsed and an error occurs, the kernel can send a message to the
> userspace describing the error through a meaningful text message in
> addition to the classic error code.
> 
> Signed-off-by: Andrea Mayer <andrea.mayer@...roma2.it>
> ---
>  net/ipv6/seg6_local.c | 44 +++++++++++++++++++++++++++----------------
>  1 file changed, 28 insertions(+), 16 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>