netdev - Re: [PATCH] bnxt_en: fix flags to check for supported fw version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YyTBFpZcPU6w3qST@C02YVCJELVCG.dhcp.broadcom.net>
Date:   Fri, 16 Sep 2022 14:31:50 -0400
From:   Andy Gospodarek <andrew.gospodarek@...adcom.com>
To:     Vadim Fedorenko <vfedorenko@...ek.ru>
Cc:     Michael Chan <michael.chan@...adcom.com>,
        Pavan Chebbi <pavan.chebbi@...adcom.com>,
        netdev@...r.kernel.org, Richard Cochran <richardcochran@...il.com>
Subject: Re: [PATCH] bnxt_en: fix flags to check for supported fw version

On Fri, Sep 16, 2022 at 02:49:32AM +0300, Vadim Fedorenko wrote:
> The warning message of unsupported FW appears every time RX timestamps
> are disabled on the interface. The patch fixes the flags to correct set
> for the check.
Looks good to me.  Thanks for sending this.

> Fixes: 66ed81dcedc6 ("bnxt_en: Enable packet timestamping for all RX packets")
> Cc: Richard Cochran <richardcochran@...il.com>
> Signed-off-by: Vadim Fedorenko <vfedorenko@...ek.ru>
Reviewed-by: Andy Gospodarek <gospo@...adcom.com>

> ---
>  drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c
> index 7f3c0875b6f5..8e316367f6ce 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c
> @@ -317,9 +317,9 @@ void bnxt_ptp_cfg_tstamp_filters(struct bnxt *bp)
>  
>  	if (!(bp->fw_cap & BNXT_FW_CAP_RX_ALL_PKT_TS) && (ptp->tstamp_filters &
>  	    (PORT_MAC_CFG_REQ_FLAGS_ALL_RX_TS_CAPTURE_ENABLE |
> -	     PORT_MAC_CFG_REQ_FLAGS_PTP_RX_TS_CAPTURE_DISABLE))) {
> +	     PORT_MAC_CFG_REQ_FLAGS_ALL_RX_TS_CAPTURE_DISABLE))) {
>  		ptp->tstamp_filters &= ~(PORT_MAC_CFG_REQ_FLAGS_ALL_RX_TS_CAPTURE_ENABLE |
> -					 PORT_MAC_CFG_REQ_FLAGS_PTP_RX_TS_CAPTURE_DISABLE);
> +					 PORT_MAC_CFG_REQ_FLAGS_ALL_RX_TS_CAPTURE_DISABLE);
>  		netdev_warn(bp->dev, "Unsupported FW for all RX pkts timestamp filter\n");
>  	}
>  

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4222 bytes)