netdev - Re: [PATCH net-next,v4 0/9] refactor duplicate codes in the tc cls walk function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM0EoMmcjfjg+7RsMtW_4YWb+4ewACGW=YVtzOU0Xqh=Kk_K-g@mail.gmail.com>
Date:   Sun, 18 Sep 2022 21:05:29 -0400
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Victor Nogueira <victor@...atatu.com>
Cc:     Zhengchao Shao <shaozhengchao@...wei.com>, netdev@...r.kernel.org,
        bpf@...r.kernel.org, linux-kselftest@...r.kernel.org,
        xiyou.wangcong@...il.com, jiri@...nulli.us, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        shuah@...nel.org, ast@...nel.org, daniel@...earbox.net,
        andrii@...nel.org, martin.lau@...ux.dev, song@...nel.org,
        yhs@...com, john.fastabend@...il.com, kpsingh@...nel.org,
        sdf@...gle.com, haoluo@...gle.com, jolsa@...nel.org,
        weiyongjun1@...wei.com, yuehaibing@...wei.com
Subject: Re: [PATCH net-next,v4 0/9] refactor duplicate codes in the tc cls
 walk function

On Fri, Sep 16, 2022 at 12:56 PM Victor Nogueira <victor@...atatu.com> wrote:
>
>
> On 15/09/2022 23:02, Zhengchao Shao wrote:
> > The walk implementation of most tc cls modules is basically the same.
> > That is, the values of count and skip are checked first. If count is
> > greater than or equal to skip, the registered fn function is executed.
> > Otherwise, increase the value of count. So the code can be refactored.
> > Then use helper function to replace the code of each cls module in
> > alphabetical order.
> >
> > The walk function is invoked during dump. Therefore, test cases related
> >   to the tdc filter need to be added.
> >
> > Last, thanks to Jamal, Victor and Wang for their review.
> >
> > Add test cases locally and perform the test. The test results are listed
> > below:
> >

>
> Reviewed-by: Victor Nogueira <victor@...atatu.com>
> Tested-by: Victor Nogueira <victor@...atatu.com>

For the series:
Acked-by: Jamal Hadi Salim <jhs@...atatu.com>

cheers,
jamal