[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20220920192708.jcvyph3ec7lscuqj@pengutronix.de>
Date: Tue, 20 Sep 2022 21:27:08 +0200
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, davem@...emloft.net,
linux-can@...r.kernel.org, kernel@...gutronix.de
Subject: Re: [PATCH net 0/17] pull-request: can 2022-09-20
On 20.09.2022 12:22:46, Jakub Kicinski wrote:
> On Tue, 20 Sep 2022 11:28:58 +0200 Marc Kleine-Budde wrote:
> > The next 15 patches are by Anssi Hannula and Jimmy Assarsson and fix
> > various problem in the kvaser_usb CAN driver.
>
> These are large patches which don't clearly justify the classification
> as a fix. Patches 6 and 8 for example leave me asking "what does this
> fix?" It's good to report errors, but the absence of error reporting
> is not necessarily a bug worthy of stable.
>
> Can we get the commit messages beefed up?
I'll talk to the authors, try to get better commit messages and distill
the minimum patches the need to be ported to stable.
Thanks,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists