netdev - Re: [PATCH net 0/2] Revert fec PTP changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9165d763-ec2c-3014-cebf-121934ad93f3@leemhuis.info>
Date:   Tue, 20 Sep 2022 09:45:39 +0200
From:   Thorsten Leemhuis <regressions@...mhuis.info>
To:     Francesco Dolcini <francesco.dolcini@...adex.com>,
        Marc Kleine-Budde <mkl@...gutronix.de>
Cc:     Joakim Zhang <qiangqing.zhang@....com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Csókás Bence <csokas.bence@...lan.hu>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Guenter Roeck <linux@...ck-us.net>,
        Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH net 0/2] Revert fec PTP changes

On 12.09.22 14:38, Francesco Dolcini wrote:
> On Mon, Sep 12, 2022 at 02:28:57PM +0200, Marc Kleine-Budde wrote:
>> On 12.09.2022 09:01:41, Francesco Dolcini wrote:
>>> Revert the last 2 FEC PTP changes from Csókás Bence, they are causing multiple
>>> issues and we are at 6.0-rc5.
>>>
>>> Francesco Dolcini (2):
>>>   Revert "fec: Restart PPS after link state change"
>>>   Revert "net: fec: Use a spinlock to guard `fep->ptp_clk_on`"
>>
>> Nitpick: I would revert "net: fec: Use a spinlock to guard
>> `fep->ptp_clk_on`" first, as it's the newer patch.
> 
> Shame on me, I do 100% agree, I inverted the 2 patches last second.

What's the status of this patchset? It seems it didn't make any progress
in the past few days, or am I missing something?

Just asking, because the thing is: I'm pretty sure that Linus will be
somewhat unhappy if there isn't any attempt to get this fixed before
rc7, as the the problems caused by these patches are known for a while now.

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)

P.S.: As the Linux kernel's regression tracker I deal with a lot of
reports and sometimes miss something important when writing mails like
this. If that's the case here, don't hesitate to tell me in a public
reply, it's in everyone's interest to set the public record straight.